Changelog, metrics manual instrumentation docs, and 1.3.0 pre-release changes #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,13 +22,63 @@ The following dimensions are automatically added to all metrics exported by the | |||
| | `process.pid` | The Java process identifier (PID). | |||
| | `service` | The value of the `service.name` resource attribute. | |||
|
|
|||
| ## Manual instrumentation | |||
There was a problem hiding this comment.
I've noticed that I forgot to document how to manually add metrics, so I added it right now - that's a feature that needs to be described in this release's docs.
breedx-splk
reviewed
Aug 23, 2021
breedx-splk
reviewed
Aug 23, 2021
| make it very easy to accidentally put the agent on the application runtime | ||
| classpath, which may cause all sorts of problems and confusion - and the | ||
| agent won't work anyway, because it has to be passed in the `-javaagent` JVM | ||
| parameter. |
There was a problem hiding this comment.
I guess we removed this because we do publish to maven now. Might be nice to swizzle this around to say something like Q: Should I put the agent on my classpath? A: No, the agent should never be on the runtime classpath. Down the road, we could provide some gradle/mvn snippets that show how to source it without including it in the classpath....I dunno.
There was a problem hiding this comment.
Good point, will add.
breedx-splk
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.