Support OTEL_SERVICE_NAME #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
approved these changes
Jul 13, 2021
iNikem
approved these changes
Jul 13, 2021
theletterf
reviewed
Jul 14, 2021
Comment on lines
+124
to
+126
| The service name is the only configuration option that is required. You can | ||
| specify it by setting the `otel.service.name` system property as shown in the | ||
| [example above](#getting-started). |
There was a problem hiding this comment.
service.name is the only required setting. You can specify it by setting otel.service.name as in the example above.
There was a problem hiding this comment.
(I believe I can't use the suggest changes feature of GitHub if I lack proper permissions.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @theletterf - there's a small change in the README & one more property in the docs