[discovery] Move continuous discovery config parts to static files #5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
continuous-discovery
branch
from
95232c4
to
70668f2
Compare
atoulme
reviewed
Sep 17, 2024
| func setEntitiesPipelineReceivers(pipelines map[string]any, discoReceivers []any) { | ||
| ep, ok := pipelines["logs/entities"].(map[string]any) | ||
| if !ok { | ||
| // Entities pipeline not set, nothing to do. |
There was a problem hiding this comment.
would a log statement make sense here?
There was a problem hiding this comment.
Yeah makes sense. But we currently don't pass a logger here. I'll address that separately
dmitryax
force-pushed
the
continuous-discovery
branch
from
70668f2
to
615d8b1
Compare
We cannot assume that ${SPLUNK_ACCESS_TOKEN} and ${SPLUNK_REALM} are aways set. It's not the case for the helm chart. We should move static config part of continuous discovery from discoverer to the config files. Having it in the `agent_config.yaml` has no overhead until the continuous discovery is enabled.
dmitryax
force-pushed
the
continuous-discovery
branch
from
615d8b1
to
f4f2b30
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot assume that ${SPLUNK_ACCESS_TOKEN} and ${SPLUNK_REALM} are aways set. It's not the case for the helm chart. We should move static config part of continuous discovery from discoverer to the config files. Having it in the
agent_config.yamlhas no overhead until the continuous discovery is enabled.