-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/discovery] Remove first_only
field from the matching rule
#4593
Merged
+197
−388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Apr 4, 2024
|
This is another step towards moving from discovery events to the entity events. The entity events will be emitted once a new matching rule matches a metric or log statement. After the initial emit the same entity state will be emitted on a regular basis, not when we get another match. This makes the `first_only` config option conflicting with the way how the entity events are expected to be emitted. WIth this particular change, we switch behavior to `emit_first=true` by design. Given that all the discovery rules have the same value preconfigured, it's not a breaking change for users who rely on them. It is a breaking change for users who have custom discovery rules with emit_first=false. This is acceptable given the "In development" status of the receiver.
d0161f9
to
fdd17b9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another step towards moving from discovery events to the entity events. The entity events will be emitted once a new matching rule matches a metric or log statement. After the initial emit the same entity state will be emitted on a regular basis, not when we get another match. This makes the
first_only
config option conflicting with the way how the entity events are expected to be emitted.WIth this particular change, we switch behavior to
emit_first=true
by design. Given that all the discovery rules have the same value preconfigured, it's not a breaking change for users who rely on them. It is a breaking change for users who have custom discovery rules with emit_first=false. This is acceptable given the "In development" status of the receiver.