-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bundled k8s smartagent/postgres discovery rules #3023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmfitzpatrick
force-pushed
the
bundledpostgresk8s
branch
from
April 26, 2023 13:41
d08151d
to
2892918
Compare
rmfitzpatrick
commented
Apr 26, 2023
theletterf
reviewed
Apr 26, 2023
...nal/confmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml
Outdated
Show resolved
Hide resolved
...nal/confmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml
Outdated
Show resolved
Hide resolved
...nal/confmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml
Outdated
Show resolved
Hide resolved
...nal/confmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml
Outdated
Show resolved
Hide resolved
...nal/confmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml
Outdated
Show resolved
Hide resolved
...onfmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
theletterf
reviewed
Apr 26, 2023
...onfmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
...onfmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
...onfmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
...onfmapprovider/discovery/bundle/bundle.d/receivers/smartagent-postgresql.discovery.yaml.tmpl
Outdated
Show resolved
Hide resolved
Co-authored-by: Fabrizio Ferri-Benedetti <fferribenedetti@splunk.com>
pmcollins
approved these changes
Apr 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: #3004These changes update the bundle.d smartagent/postgres config to support the k8s observer, add a couple partial status rules for db config guidance, and fix the default host observer rule. Also including a happy path integration test.