Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct invalid monitor ID encoding #269

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Correct invalid monitor ID encoding #269

merged 1 commit into from
Apr 13, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

#266 introduced a regression where monitor ids with unsupported characters are not used as monitorID dimension values, causing the collectd write server to drop points. Instead of url encoding these changes strip all non-word characters.

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #269 (08a5ab2) into main (c213260) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   86.93%   86.93%           
=======================================
  Files          20       20           
  Lines        1492     1492           
=======================================
  Hits         1297     1297           
  Misses        160      160           
  Partials       35       35           
Impacted Files Coverage Δ
internal/receiver/smartagentreceiver/receiver.go 91.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c213260...08a5ab2. Read the comment docs.

@rmfitzpatrick rmfitzpatrick merged commit 53e4659 into main Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the sa_monitor_ids branch April 13, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants