Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use agent bundle-relative Collectd ConfigDir default #263

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

Instead of using the Smart Agent default for the collectd config directory setting value, these changes introduce an agent-bundle relative location (~${bundleDir}/run/collectd) for more intuitive organization.

Thanks to @bjsignalfx for initial leg work in #241

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #263 (2ec35a5) into main (75dfd86) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   86.83%   86.91%   +0.07%     
==========================================
  Files          20       20              
  Lines        1481     1490       +9     
==========================================
+ Hits         1286     1295       +9     
  Misses        160      160              
  Partials       35       35              
Impacted Files Coverage Δ
internal/extension/smartagentextension/config.go 92.40% <100.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75dfd86...2ec35a5. Read the comment docs.

@rmfitzpatrick rmfitzpatrick merged commit fc10feb into main Apr 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the sa_config_dir_default branch April 12, 2021 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants