code review

signalfx · Aug 3, 2023 · 8ef36d2 · 8ef36d2
1 parent f0936cc
commit 8ef36d2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/cmd/otelcol/config/collector/agent_config.yaml b/cmd/otelcol/config/collector/agent_config.yaml
@@ -161,6 +161,9 @@ exporters:
     verbosity: detailed
 
 service:
+  telemetry:
+    metrics:
+      address: "${SPLUNK_LISTEN_INTERFACE}:8888"
   extensions: [health_check, http_forwarder, zpages, memory_ballast, smartagent]
   pipelines:
     traces:

diff --git a/cmd/otelcol/config/collector/gateway_config.yaml b/cmd/otelcol/config/collector/gateway_config.yaml
@@ -121,6 +121,9 @@ exporters:
     log_data_enabled: false
 
 service:
+  telemetry:
+    metrics:
+      address: "${SPLUNK_LISTEN_INTERFACE}:8888"
   extensions: [health_check, http_forwarder, zpages, memory_ballast]
   pipelines:
     traces:

diff --git a/tests/general/default_config_test.go b/tests/general/default_config_test.go
@@ -35,9 +35,8 @@ func TestDefaultGatewayConfig(t *testing.T) {
 		"",
 		func(collector testutils.Collector) testutils.Collector {
 			return collector.WithArgs().WithEnv(map[string]string{
-				"SPLUNK_LISTEN_INTERFACE": "0.0.0.0",
-				"SPLUNK_ACCESS_TOKEN":     "not.real",
-				"SPLUNK_REALM":            "not.real",
+				"SPLUNK_ACCESS_TOKEN": "not.real",
+				"SPLUNK_REALM":        "not.real",
 			})
 		},
 	)
@@ -198,9 +197,8 @@ func TestDefaultAgentConfig(t *testing.T) {
 			return collector.WithArgs(
 				"--config", "/etc/otel/collector/agent_config.yaml",
 			).WithEnv(map[string]string{
-				"SPLUNK_LISTEN_INTERFACE": "0.0.0.0",
-				"SPLUNK_ACCESS_TOKEN":     "not.real",
-				"SPLUNK_REALM":            "not.real",
+				"SPLUNK_ACCESS_TOKEN": "not.real",
+				"SPLUNK_REALM":        "not.real",
 			})
 		},
 	)