Skip to content

Commit

Permalink
Mark error return by prepare as permanent (#56)
Browse files Browse the repository at this point in the history
The errors are: marshaling or gzipping which both will fail in case of a retry.

Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
  • Loading branch information
Bogdan Drutu authored Feb 22, 2022
1 parent d6e6e9f commit 02976b3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion client/worker.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (w *worker) export(ctx context.Context, batches []*jaegerpb.Batch, accessTo
span.RecordError(err)
span.SetStatus(codes.Error, "")
recordEncodingFailure(ctx, sr)
return &ErrSend{Err: err}
return &ErrSend{Err: err, Permanent: true}
}

serr := w.send(ctx, sr, accessToken)
Expand Down

0 comments on commit 02976b3

Please sign in to comment.