Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to prost 0.9 #425

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Update to prost 0.9 #425

merged 1 commit into from
Nov 29, 2021

Conversation

rubdos
Copy link
Contributor

@rubdos rubdos commented Nov 28, 2021

Prost 0.9 contains some performance improvement for varint, and allows developers to work on Apple silicon.

https://github.com/tokio-rs/prost/releases/tag/v0.9.0

Technically this is a breaking change (because prost::DecodeError is exposed through SignalProtocolError), so you'll want to bump to 0.12 after this.

@jrose-signal
Copy link
Contributor

Thank you! As an aside, the version numbers are more for Signal-internal use, so they track the stability of the Java, Swift, and TypeScript interfaces rather than the Rust crate (which is why that's stuck at 0.1.0).

@jrose-signal jrose-signal merged commit fd4b2b7 into signalapp:main Nov 29, 2021
@rubdos rubdos deleted the prost-push branch November 30, 2021 18:05
@rubdos
Copy link
Contributor Author

rubdos commented Nov 30, 2021

Thank you! As an aside, the version numbers are more for Signal-internal use, so they track the stability of the Java, Swift, and TypeScript interfaces rather than the Rust crate (which is why that's stuck at 0.1.0).

Aha, I see. Maybe I should make a separate issue about this, but would it at a certain point be possible to start versioning the crate as well?

@jrose-signal
Copy link
Contributor

Circling back to this: after some discussion we're going to do best-effort versioning for the (non-bridge) Rust APIs as well, though for now I think we'll continue treating the version number as a workspace version number rather than tracking things on a per-crate level. (That is, a change in signal-crypto's API would bump the overall version number, even if libsignal-protocol didn't change.)

@rubdos
Copy link
Contributor Author

rubdos commented Dec 23, 2021

That sounds very usable to me already :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants