-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic removal of messages based on a time (or number of messages per thread?) #254
Comments
Wondering if this should be time-based or depending on number of interactions with a given contact. |
how is this done on android? we have a big philosopher for fewer settings. On Wed, Dec 31, 2014 at 2:18 PM, Frederic Jacobs notifications@github.com
Dr. Corbett Moran |
I put this on My preference leans towards a slider that lets you define how many messages you want to keep max per conversation. Default value (middle of the slider) would be 50 or something. |
I think we should sync up with android and have the same settings available On Wed, Dec 31, 2014 at 4:34 PM, Frederic Jacobs notifications@github.com
Dr. Corbett Moran |
cool, let's do that then (but egads so many settings) On Fri, Jan 2, 2015 at 9:52 PM, Frederic Jacobs notifications@github.com
Dr. Corbett Moran |
Clarifying question @corbett and @FredericJacobs, please mention me in your answer: would the conversation history still be available on the server side, and just the local copies deleted? So you'd have a pull to refresh style "loading more messages" UI like most other clients? Or would they just be gone forever? |
@abolishme conversation history is never available server side. the server On Fri, Feb 27, 2015 at 1:46 PM, Tyler Reinhard notifications@github.com
Dr. Corbett Moran |
One concern I have @FredericJacobs and @corbett: if someone texted me something I want to save, then they send me 200 texts tomorrow and the max-message X was set to 200, i would lose it? If that's the case, we should make it possible to pin/save messages that won't disappear with the rest (snapchat does this) ... i'll add that to my brainstorm list. |
@abolishme: Keep it simple. We already have enough complexity with archiving and deleting. Pinning is really not needed. |
There wouldn't be an easy and secure way to save messages like that without something similar to #738. How well would this cooperate on its own, or with existing anonymity systems where users really are in a very desperate situation regarding communications? |
I agree it should mirror the android 'Delete old messages' option as seen in the above picture. Then there won't be any confusion! :) Can't wait to see this implemented in iOS. Edit2: Since the introduction of timed messages this issue is essentially solved. Congratulations! |
This is an essential, yet missing feature: inactivity-based deletion. The best way to analogize this would be to talk about it like Google's inactive account manager. After a certain period of time of the app/device not being used, a message would then automatically be deleted. Otherwise, if the person continues use of app, no auto delete for older messages. The importance of this time-based deletion policy cannot be overstated for unapproved searches and/or seizures of devices for local attacks. |
👍 I also would like to see the "Delete old messages" option (which is in the Android version) in the iOS version. |
While this issue is a feature request and so should be closed regardless, I can additionally confirm this feature has been implemented and shipped to production in 2.38.1.2 in the form of "Disappearing messages". To use feature: click on a chat in the chats list, click on "Tap here for settings" next to contact avatar on UINavigationBar, toggle the "Disappearing Messages" switch and adjust duration for message lifetime using the revealed slider. An announcement of the feature was made on the blog on 11 Oct 2016 and there is a Signal support page with slightly more detailed usage instructions. |
@tomj However please note that the specific feature shown in #254 (comment) is not implemented in iOS. I'm not sure if the Conversation trimming based on message count is available on Android but surely it's not available on iOS, while Disappearing messages is available on all platforms. Conversation trimming based on message count |
@u32i64 thanks for the heads up - my closure recommendation was based on the current issue title but I get what you're saying about that comment. Regardless of whether it has been shipped to prod, this issue is a feature request and should be recognised as such in some form, and closed/transferred to a listing of feature requests. From there any further discussion can ensue in a separate but related thread. Here's a placeholder for now to keep track of any further discussion you want to throw out while the upstream krew work out a strategy to pipeline feature request issues to working feature requests and clear out this backlog. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
My Signal database is eating 11GB of valuable space in my iPhone. This is the biggest data consumer in my phone. |
How is this issue closed? How can you justify an ever increasing consumption of space? |
It's technically really easy to implement since we're already using a similar database index to sort messages in the MessagesViewController.
Ephemerality ftw
The text was updated successfully, but these errors were encountered: