Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow file attachments of any type #6939

Closed
wants to merge 3 commits into from

Conversation

FXZFun
Copy link

@FXZFun FXZFun commented Jul 15, 2024

First time contributor checklist:

Contributor checklist:

  • My contribution is not related to translations.
  • My commits are in nice logical chunks with good commit messages
  • My changes are rebased on the latest main branch
  • A npm run ready run passes successfully (more about tests here)
  • My changes are ready to be shipped to users

Description

Summary:
This PR introduces an option in chat settings to enable sharing files of any type in the Desktop application, aligning it with the functionality available on other platforms.

Motivation:
Allowing the sharing of various file types significantly reduces friction for developers and technical users who need to share code, app files, etc. Repeated personal experience with this led to the creation of this PR.

Details:

  • Scope: Desktop application only. Other platforms already support all file types.
  • Default Setting: The option is disabled by default, requiring users to opt-in via chat settings.
  • Conventions: Every effort was made to follow the conventions in the rest of the codebase. Any comments/changes are welcome.
  • Testing: Manual testing confirms the UI change in settings and proper handling for upload/download of files with the setting both enabled and disabled.

Testing Environment:

  • Operating System: Windows 11 x64
  • Tests Conducted:
    • Verified UI changes in chat settings
    • Tested file upload/download functionality with the setting both enabled and disabled

Visuals:

image

Related Discussions:

Related Issues:

Resolves #930
Resolves #3840
Resolves #3849
Resolves #5142
Resolves #6890

@indutny-signal
Copy link
Contributor

Thank you so much for opening this PR! While I understand where the motivation for this feature is coming from, at this time (just as mentioned in all the issues you linked to) this isn't planned. Thus unfortunately, I have to close this Pull Request.

@computator
Copy link

Why is this not allowed, seeing as these restrictions do not exist on the mobile version? I would expect the desktop and mobile versions to have the same restrictions (or lack thereof).

I don't see any responses with an explanation or rationale in any of the linked tickets or discussions?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment