Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Hide phone numbers in conversation headers #3647

Closed
wants to merge 2 commits into from

Conversation

char
Copy link

@char char commented Oct 4, 2019

First time contributor checklist:

Contributor checklist:

Description

This is a pull request that adds a 'Hide phone numbers in conversation headers' option to the preferences.

This solves #3561 and #1741.

@char
Copy link
Author

char commented Oct 4, 2019

I'm having some issues where sometimes the Preferences page fails to load. Can somebody help out? It doesn't seem to be consistent at all.

@scottnonnenberg-signal
Copy link
Contributor

I'm going to close this, as we need to think very hard about any new option we add. We want to avoid complexity for our users wherever possible. As far as the original issue we're trying to address with these changes, we have other ideas about how to address it.

@abowerman
Copy link

abowerman commented Jan 7, 2020

Phone numbers should still be hidden in the UI by default.

RE: #3561 / #1741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants