Skip to content

Commit

Permalink
Remove existing global hamburger menu
Browse files Browse the repository at this point in the history
This will be replaced by a OS-level ‘Preferences’ menu.
  • Loading branch information
gasi committed Mar 2, 2018
1 parent f5adb37 commit 2f144d2
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 33 deletions.
10 changes: 0 additions & 10 deletions background.html
Original file line number Diff line number Diff line change
Expand Up @@ -69,16 +69,6 @@
<div class='gutter'>
<div class='network-status-container'></div>
<div class='title-bar active' id='header'>
<div class='header-buttons right'>
<div class='vertical-align'>
<div class='global-menu menu'>
<button class='hamburger' alt='signal menu'></button>
<ul class='menu-list'>
<li class='showSettings'>{{ settings }}</li>
</ul>
</div>
</div>
</div>
<h1>Signal</h1>
<div class='tool-bar clearfix'>
<input type='search' class='search' placeholder='{{ searchForPeopleOrGroups }}' dir='auto'>
Expand Down
13 changes: 0 additions & 13 deletions js/views/inbox_view.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@
click: 'onClick',
'click #header': 'focusHeader',
'click .conversation': 'focusConversation',
'click .global-menu .hamburger': 'toggleMenu',
'click .showSettings': 'showSettings',
'select .gutter .conversation-list-item': 'openConversation',
'input input.search': 'filterContacts',
'show .lightbox': 'showLightbox',
Expand Down Expand Up @@ -258,9 +256,6 @@
this.focusConversation();
}
},
toggleMenu() {
this.$('.global-menu .menu-list').toggle();
},
showLightbox(e) {
this.$el.append(e.target);
},
Expand All @@ -270,15 +265,7 @@
}
this.$('.conversation:first .recorder').trigger('close');
},
closeMenu(e) {
if (e && this.$(e.target).parent('.global-menu').length > 0) {
return;
}

this.$('.global-menu .menu-list').hide();
},
onClick(e) {
this.closeMenu(e);
this.closeRecording(e);
},
});
Expand Down
10 changes: 0 additions & 10 deletions test/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -41,16 +41,6 @@
<div class='gutter'>
<div class='network-status-container'></div>
<div class='title-bar active' id='header'>
<div class='header-buttons right'>
<div class='vertical-align'>
<div class='global-menu menu'>
<button class='hamburger' alt='signal menu'></button>
<ul class='menu-list'>
<li class='showSettings'>{{ settings }}</li>
</ul>
</div>
</div>
</div>
<h1>Signal</h1>
<div class='tool-bar clearfix'>
<input type='search' class='search' placeholder='{{ searchForPeopleOrGroups }}' dir='auto'>
Expand Down

0 comments on commit 2f144d2

Please sign in to comment.