Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of cosmetic corrections for strings.xml #3364

Closed
wants to merge 1 commit into from
Closed

Couple of cosmetic corrections for strings.xml #3364

wants to merge 1 commit into from

Conversation

RiseT
Copy link
Contributor

@RiseT RiseT commented Jun 7, 2015

I've made a couple of very minor cosmetic corrections (mostly punctuation) of the original strings which I noticed when translating at Transifex.
Each one of them is about consistency and conformity with similar strings.

While I'm pretty sure about the correctness of the changes, I'm an absolute novice to GitHub - sorry in advance if I violate some formal conventions for commiting at GitHub or do something stupid in the process.

I've made a couple of very minor cosmetic corrections (mostly punctuation) of the original strings which I noticed when translating at Transifex.
Each one of them is about consistency and conformity with similar strings.

While I'm pretty sure about the correctness of the changes, I'm an absolute novice to GitHub - sorry in advance if I violate some formal conventions for commiting at GitHub.
@mcginty
Copy link
Contributor

mcginty commented Jun 8, 2015

Thanks @RiseT, not having ellipses in the title does seem nicer. All these look good to me.

@RiseT
Copy link
Contributor Author

RiseT commented Jun 8, 2015

@mcginty I've changed them as pretty much all TextSecure dialogs of that kind don't have ellipses in the title but they do in the description text. Those are aberrations.

moxie0 pushed a commit that referenced this pull request Jun 9, 2015
@moxie0
Copy link
Contributor

moxie0 commented Jun 9, 2015

In 2.18.0

@moxie0 moxie0 closed this Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants