Use a multi-stage Dockerfile to have slimmer image #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanji
reviewed
Mar 14, 2018
docker/Dockerfile
Outdated
|
|
||
| RUN rm -rf /go/src /go/pkg && apk --no-cache del make git musl-dev | ||
| RUN mkdir /lib64 && ln -s /lib/libc.musl-x86_64.so.1 /lib64/ld-linux-x86-64.so.2 | ||
| #RUN mkdir /lib64 && ln -s /lib/libc.musl-x86_64.so.1 /lib64/ld-linux-x86-64.so.2 |
There was a problem hiding this comment.
I see you have commented this, is there a particular reason for doing it?
There was a problem hiding this comment.
It's a relic. I wasn't sure whether it's still needed. Turned out it's apparently not.
I've removed the line.
DrMurx
force-pushed
the
slimmer_docker_image
branch
from
b35444a to
2c3f8a1
Compare
DrMurx
pushed a commit
to erasys/mariadb-ha-test
that referenced
this pull request
Mar 16, 2018
While signal18/replication-manager#217 is open, provide a dedicated build context for a smaller image
|
OK. Sorry for the late reply (was on vacations). The image works great even without the symbolic link. Therefore I am merging this PR. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the docker image by using a multistage Dockerfile. This allows to keep build-time dependencies in a dedicated container.
The previous implementation just deleted the build tools, but due to docker's layering schema they were still hidden in lower layers, leading to a unnecessary big image (729MB).
The actual image of the final build stage is based on a plain alpine:3.7 and is only 36MB.