Stabilize path for libusb devices #406
Conversation
|
FWIW, I tested this on debian linux, with the crelay tool, and it works like a charm! |
|
Please consider making this PR to https://github.com/libusb/hidapi |
Sorry, while I know git pretty well, I'm not a github expert, so I'm not sure how to tell github to let me submit this to libusb/hidapi. The straightforward way seems to not recognize my branch as a fork. It looks like libusb/hidapi is not a fork of this repo, which implies I'd need to manually rebuild this change? Or is there a better way? |
|
You definitely need to make another fork of a new repository, and apply your changes on top of it in any feasible way. |
|
@Youw -- I figured that. I don't think my system is actually using libusb/hidapi, so I have no way to actually test that the change would work. I can certainly apply it blindly, and ensure it builds, but I'm not sure that helps anyone if I can't actually test it. Someone else is certainly welcome to copy my code and build a PR against libusb/hidapi. |
|
Do you mind sharing what "your system" is? |
Fedora 29 (although it was FC25 when I did the work). The libhid they provide is the signal11 version, not the one from libusb. Specifically: |
|
Well. Alan is not answering last couple of years, and he is the only maintainer of this repository, so, technically, it is abandoned. See discussion here: #373 (comment) We hope, that all dists, that consider them up-to-date will switch to https://github.com/libusb/hidapi eventually, but there still a lot of hard work to do, before that can happen. |
|
@Youw -- Yes, I saw #373 and will try to migrate my PR over there, but like I said above, someone else is welcome to port my changes over if I don't get to it. Frankly I did it because I needed the functionality. Until my distro does migrate I don't have a high need to port the change (but you're right, I should make sure the change gets ported before my distro updates...) |
`kIOMasterPortDefault` is deprecated since macOS 12.0. One alternative is to use named constant `kIOMainPortDefault` which is not available before macOS 12.0. Both named constants are just an alias for `NULL`, so it is simpler to use it directly instead. Fixes: signal11#377
This path helps deal with certain HID devices that don't have serial numbers (e.g. the Sainsmart HID 16 relay). This uses the libusb physical path to stabilize the PATH so that unplugged and replugging the device does not change the path -- and boot order does not affect it, either. Unfortunately the get_address() API is not stable across plug-ins.