windows: retry open_device() without r/w if it fails #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modern Windows implementations don't allow opening HID devices in READ/WRITE mode if they are claimed by the system. Examples of such devices include keyboards and mice. However, these devices can be opened without READ/WRITE permissions, in order to allow sending and receiving feature reports. If open_device() fails, retry without requesting READ/WRITE permissions. This inverts the logic of the parameter to open_device(). It is a refactor of signal11#44 by @pqu. Signed-off-by: Sean Cross <sean@xobs.io>
This was referenced Jun 3, 2019
Megamouse
pushed a commit
to Megamouse/hidapi
that referenced
this pull request
Jan 1, 2022
`SUBSYSTEMS` should be used instead of `SUBSYSTEM` for "usb" match. Fixes: signal11#335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modern Windows implementations don't allow opening HID devices in
READ/WRITE mode if they are claimed by the system. Examples of such
devices include keyboards and mice.
However, these devices can be opened without READ/WRITE permissions, in
order to allow sending and receiving feature reports.
If open_device() fails, retry without requesting READ/WRITE permissions.
This inverts the logic of the parameter to open_device().
It is a refactor of #44 by @pqu.
Tested on Windows 10 15063.
Signed-off-by: Sean Cross sean@xobs.io