add auto open auth link #187
Conversation
|
Thanks! I edited your PR title to not say it "closes that community issue". We'll close it only once the fix is released. |
There was a problem hiding this comment.
LGTM on MacOS - @daniel-de-vera , can you please give this a test on Linux and approve?
Yes, it works on Ubuntu. |
internal/command/auth/login.go
Outdated
| } else { | ||
| fmt.Fprintf(out, "Opening browser to authenticate at: %s\n", code.VerificationURI) | ||
| } | ||
| fmt.Fprintf(out, "Enter the code: %s\n\n", code.UserCode) |
There was a problem hiding this comment.
I would keep here the confirm verb instead of enter, as @scott-cotton mentioned in the original PR: #179 (review).
|
I had a regression with this change when I had a CLI built off this version - specifically it refused to apply sandboxes and kept saying I was not logged in. It may not be related to this change directly, but it's worth retesting after rebase and checking that this actually works. |
|
@foxish any error in particular? |
davixcky
force-pushed
the
add-auto-open-auth-link
branch
from
cede47b to
f43cc45
Compare
|
@foxish I was able to repro, fixed with the rebase |
|
This needs another rebase @davixcky - let's get it in for the next release. |
|
going ahead and merging for release |
Now when doing
signadot auth loginwe will automatically open the default browser. Depending of the host we will trigger or use some app.This is part of signadot/community#86