-
Notifications
You must be signed in to change notification settings - Fork 12
Feature/fix bare citations script #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AmitMY
merged 21 commits into
sign-language-processing:master
from
cleong110:feature/fix_bare_citations_script
Jul 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
78db2ef
CDL: script that checks for known citation keys without @ symbol
2017fbb
CDL: added bare-citation fix to Makefile
fbfcdb4
github action to check for bare citations
73b47ce
update and rename citation-check script to work with github actions
07c7310
CDL: couple typos and fixes in citation check workflow
d14cec8
updated find_bare_citations.py to skip comment blocks
399406e
CDL: remove citation-fix from Makefile
625d0b9
CDL: switch to argparse+Path
893fecf
Optimization changes for running faster
0f5269a
Requested change to use yield
2675b7e
CDL: fix return value
148fe46
CDL: actually fix return value
8662a6a
Revert "CDL: fix return value", wrong file.
ffe8da4
MUCH faster citation check by simpler regex
30f8166
CDL: edited citation-extraction as requested
9115d4a
CDL: some cleanup items
3ed73ea
CDL: eliminate redundant var assignment
a686e9d
bare-citation-check: Only find line if issue exists
0f4f831
CDL: updating type hints
26c5bc7
CDL: adding a comment
4bfed6a
CDL: fixing the type hint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
CDL: added bare-citation fix to Makefile
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.