Fix - prevent panic on GetTrimmedParam (gofiber#1593)

Close gofiber#1587
sigmundxia · Oct 25, 2021 · 87b0a15 · 87b0a15
1 parent 658b4e4
commit 87b0a15
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/path.go b/path.go
@@ -350,7 +350,7 @@ func GetTrimmedParam(param string) string {
 	start := 0
 	end := len(param)
 
-	if param[start] != paramStarterChar { // is not a param
+	if end == 0 || param[start] != paramStarterChar { // is not a param
 		return param
 	}
 	start++

diff --git a/path_test.go b/path_test.go
@@ -420,7 +420,9 @@ func Test_Path_matchParams(t *testing.T) {
 
 func Test_Utils_GetTrimmedParam(t *testing.T) {
 	t.Parallel()
-	res := GetTrimmedParam("*")
+	res := GetTrimmedParam("")
+	utils.AssertEqual(t, "", res)
+	res = GetTrimmedParam("*")
 	utils.AssertEqual(t, "*", res)
 	res = GetTrimmedParam(":param")
 	utils.AssertEqual(t, "param", res)