[embed link sharing] Add workbook:sharinglink:update #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiranmayaGundu
requested changes
Aug 1, 2024
.changeset/many-feet-kick.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@sigmacomputing/embed-sdk": minor | |||
There was a problem hiding this comment.
You need to add a changeset for the react-embed-sdk as well. You want to pick up the new embed sdk dependency.
| @@ -94,6 +96,18 @@ export const workbookVariableCurrentListener = ( | |||
| } | |||
| }; | |||
|
|
|||
| export const workbookLinkSharingUpdateListener = ( | |||
There was a problem hiding this comment.
you should add an api for this is the react-embed-sdk
HiranmayaGundu
approved these changes
Aug 1, 2024
HiranmayaGundu
pushed a commit
that referenced
this pull request
Sep 16, 2024
* workbook:sharinglink:update * add workbookSharingLinkUpdate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
workbook:sharinglink:update