Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dr module velero configurations to schema #282

Merged
merged 5 commits into from
Oct 28, 2024
Merged

feat: add dr module velero configurations to schema #282

merged 5 commits into from
Oct 28, 2024

Conversation

alessiodionisi
Copy link
Contributor

Changes

  • Added DR Velero missing .spec.distribution.modules.dr.velero.schedules configurations.
  • Added DR Velero TTL configuration.

Closes #266.

@alessiodionisi alessiodionisi self-assigned this Oct 23, 2024
ralgozino
ralgozino requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ciao Ale,

I left some suggestions for the docs and for the logic on the default values. Please note that the CI is failing (I haven't checked why)

schemas/private/ekscluster-kfd-v1alpha2.json Outdated Show resolved Hide resolved
schemas/private/ekscluster-kfd-v1alpha2.json Outdated Show resolved Hide resolved
schemas/private/ekscluster-kfd-v1alpha2.json Outdated Show resolved Hide resolved
schemas/private/ekscluster-kfd-v1alpha2.json Outdated Show resolved Hide resolved
schemas/private/ekscluster-kfd-v1alpha2.json Outdated Show resolved Hide resolved
schemas/public/onpremises-kfd-v1alpha2.json Outdated Show resolved Hide resolved
schemas/public/onpremises-kfd-v1alpha2.json Outdated Show resolved Hide resolved
defaults/ekscluster-kfd-v1alpha2.yaml Outdated Show resolved Hide resolved
templates/distribution/manifests/dr/patches/velero-schedule-full.yml.tpl Outdated Show resolved Hide resolved
templates/distribution/manifests/dr/patches/velero-schedule-manifests.yml.tpl Outdated Show resolved Hide resolved
ralgozino
ralgozino approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@ralgozino ralgozino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alessiodionisi alessiodionisi merged commit c92cb2a into main Oct 28, 2024
1 check passed
@alessiodionisi alessiodionisi deleted the dr-velero-schedules branch October 28, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralgozino ralgozino ralgozino approved these changes

@nutellinoit nutellinoit Awaiting requested review from nutellinoit

Assignees

@alessiodionisi alessiodionisi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dr: spec.distribution.modules.dr.velero.retentionTime has no effect
2 participants
@alessiodionisi @ralgozino