rust(feat): agent install works without client binaries - #734
Draft
evan-sift wants to merge 3 commits into
Draft
Conversation
A headless environment (container build, CI) has a client config directory but no client binary on PATH. Detection now counts the config directory for every harness, the skill always installs since it is plain file IO, and an MCP registration that needs the client's own CLI is skipped with a warning instead of failing the whole install. agent doctor reports an uninspectable registration as a warning rather than an error.
Image builds and other packaging environments want the agent skill at a known location rather than a client's home-directory layout. An optional --path <DIR> installs the skill there in addition to every detected client, and works even when no clients are detected at all. The directory receives SKILL.md and references/ directly; rerunning with the same --path refreshes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sift-cli agent installcurrently requires each client's own binary on PATH: Claude Code and Codex are only detected via their binaries, and the install drivesclaude mcp/codex mcpfor the MCP registration. In a headless environment (a container build, CI) there is no client binary, so the install reports "No supported AI coding clients were detected" and nothing can be installed — even though the agent skill is plain file IO.This makes the command degrade gracefully instead:
~/.claude,~/.codex) now counts as detection, matching how Cursor and OpenCode are already detected.Skipped Claude Code MCP registration: \claude` is not available on PATH. The skill is installed; rerun `sift-cli agent install` once the client is available.`) instead of failing the whole install.agent doctorreports an uninspectable registration as a warning (exit 0) rather than an error, since nothing about the Sift setup itself is broken.Conflicts (an unmanaged
siftMCP entry, an unmanaged skill directory) still block the install as before.An optional
--path <DIR>onagent installalso installs the skill into the named directory in addition to every detected client — and works with no detected clients at all — for image builds and packaging environments that want the skill at a fixed location. The directory receivesSKILL.mdandreferences/directly; rerunning with the same--pathrefreshes it.Verification
cargo test -p sift_cli— 210 passed, including end-to-end tests for the no-binary install,--pathwith no detected clients,--pathalongside a detected client, and the updated detection test.cargo clippy -p sift_cli --all-targetsandcargo fmt --checkclean..claude/, with a PATH carrying no coding clients,sift-cli agent installinstalls~/.claude/skills/sift/(SKILL.md + references), prints the skip warning, and exits 0. With an empty HOME and--path <dir>, the skill installs to the named directory and the run succeeds.