Remove mypy dependence #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Knight <nick.knight@sifive.com>
nick-knight
force-pushed
the
remove-mypy-dep
branch
from
a55ed99 to
c099327
Compare
Contributor
Author
|
Looks like CI is failing on checks for Python 3.5 and 3.6. My guess is this has to do with these being ancient/EOL. Fixing this might go beyond the scope of this PR. |
Member
|
We should probably drop Pythons 3.5, 3.6, and 3.7, since all three of them are past EOL, though probably in its own PR just to keep things tidy. We'd probably also want to add in 3.9, 3.10, and 3.11, which are the latest supported releases. |
mikeurbach
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypyis a development dependence: it is not required by users of this package.Closes #46 and closes #47