Skip to content
This repository has been archived by the owner on Jul 3, 2024. It is now read-only.

doc: fix an error if the doc is not generated from github #598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbourdelin
Copy link

@sbourdelin sbourdelin commented May 12, 2021

The commit 57c45c0 expect Sphinx to find the environment variable
RELEASE_TAG.
It seems it's only the case when the documentation is generated from
github using the workflow defined in the release.yml file.

This commit allows to generate the doc from outside github, by setting
version to the current commit id if we are on a git repository, and
"n/a" otherwise.

The commit 57c45c0 expect Sphinx to find the environment variable
RELEASE_TAG.
It seems it's only the case when the documentation is generated from
github using the workflow defined in the release.yml file.

This commit allows to generate the doc from outside github, by setting
version to the current commit id if we are on a git repository, and
"n/a" otherwise.
Copy link
Contributor

@e-puerto e-puerto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants