Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webkit version broken #185

Closed
poelzi opened this issue Nov 29, 2016 · 1 comment
Closed

webkit version broken #185

poelzi opened this issue Nov 29, 2016 · 1 comment

Comments

@poelzi
Copy link

poelzi commented Nov 29, 2016

As #147 is not added, webkit version broke.

`
[ 33%] Building CXX object CMakeFiles/QSyncthingTray.dir/sources/qst/syncconnector.cpp.o
/usr/src/build/QSyncthingTray/sources/qst/syncconnector.cpp: In member function ‘void qst::connector::SyncConnector::showWebView()’:
/usr/src/build/QSyncthingTray/sources/qst/syncconnector.cpp:110:36: error: no matching function for call to ‘qst::webview::SyncWebKitView::SyncWebKitView(QUrl&, std::pair<QString, QString>&, std::shared_ptrqst::settings::AppSettings&)’
mAuthentication, mpAppSettings));
^
In file included from /usr/src/build/QSyncthingTray/includes/qst/webview.h:22:0,
from /usr/src/build/QSyncthingTray/includes/qst/syncconnector.h:40,
from /usr/src/build/QSyncthingTray/sources/qst/syncconnector.cpp:19:
/usr/src/build/QSyncthingTray/includes/qst/syncwebkitview.h:57:3: note: candidate: qst::webview::SyncWebKitView::SyncWebKitView(const QUrl&, const Authentication&)
SyncWebKitView(const QUrl &url, const Authentication &authInfo);
^
/usr/src/build/QSyncthingTray/includes/qst/syncwebkitview.h:57:3: note: candidate expects 2 arguments, 3 provided
/usr/src/build/QSyncthingTray/includes/qst/syncwebkitview.h:56:3: note: candidate: qst::webview::SyncWebKitView::SyncWebKitView()
SyncWebKitView() = default;
^
/usr/src/build/QSyncthingTray/includes/qst/syncwebkitview.h:56:3: note: candidate expects 0 arguments, 3 provided
CMakeFiles/QSyncthingTray.dir/build.make:248: recipe for target 'CMakeFiles/QSyncthingTray.dir/sources/qst/syncconnector.cpp.o' failed
make[2]: *** [CMakeFiles/QSyncthingTray.dir/sources/qst/syncconnector.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/QSyncthingTray.dir/all' failed
make[1]: *** [CMakeFiles/QSyncthingTray.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

`

`[poelzi@horas QSyncthingTray (744ef0f)]$ git bisect good
21990db is the first bad commit
commit 21990db
Author: sieren matthias@s-r-n.de
Date: Sat Nov 26 21:24:49 2016 +0100

Move Settings intos separate class

Move Settings into a separate class.
This step is a preparation for a refactoring of other classes,
so each class can register to signals from settings.
Thus we can remove the onUpdateSettings functions being
called from Window.

:040000 040000 41b86ed3a3e5a46f8c8a5b09e9d44bd277f1b8ba f8b20c9953711daa629b8b362c392f7217d2c5d1 M includes
:040000 040000 9c79e59ea71037dc375158e97eb72c53ae2a83dc b5da9385ea821a3ec64a8cfef55d1c848f4be6be M sources
`

@sieren
Copy link
Owner

sieren commented Nov 29, 2016

Ah, damnit!
Pushed a fix to master, can you try again?

@sieren sieren closed this as completed Nov 30, 2016
@sieren sieren reopened this Nov 30, 2016
@sieren sieren closed this as completed Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants