Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QWebKit Compile Option to CI Matrix #147

Open
sieren opened this issue Aug 12, 2016 · 2 comments
Open

Add QWebKit Compile Option to CI Matrix #147

sieren opened this issue Aug 12, 2016 · 2 comments

Comments

@sieren
Copy link
Owner

sieren commented Aug 12, 2016

Should add the QWebKit Compile Time option to the Build Matrix to make sure we dont break anything during updates.

@marco-m
Copy link
Contributor

marco-m commented Jan 7, 2017

In my experience, maintaining compile-time options is always a lot of pain, to be done only if really necessary, so the question: since the same functionality is provided in the default build with QWebEngine, why not simply getting rid of the QWebKit option completely? :-)

Look at it also from a pragmatic point of view: this ticket is 7 months old, it looks like there are not enough resources to properly maintain it...

Quoting Saint-Exupéry: "perfection is finally attained not when there is no longer anything to add, but when there is no longer anything to take away ..."

😄

@sieren
Copy link
Owner Author

sieren commented Jan 7, 2017

I'd like to keep both in there for now, mainly because QtWebEngine on Debian is quite cumbersome to get running (see #138 & #145). The Interface of both classes abstracting WebKit/WebEngine in QST is identical, but on occasion I've forgotten to update either one of them leading to a break. I suppose it's only a matter of a minute to actually add this to CI ;) I really should do that, but I'm more exciting about working on the UI overhaul right now ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants