Skip to content

docs: button renaming and usage guide adaptions #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 16, 2025
Merged

docs: button renaming and usage guide adaptions #25

merged 7 commits into from
Jun 16, 2025

Conversation

flxlst09
Copy link
Collaborator

@flxlst09 flxlst09 commented Jun 2, 2025

💡 What is the current behavior?

  • Usage guide for buttons not easy to understand (primary vs. secondary buttons)
  • Naming of button variants and options not in line with common UX wording

🆕 What is the new behavior?

  • Usage guides for buttons (button, dropdown button, toggle button...) adapted
  • New naming logic: default, subtle, danger as variants with options default, outline and ghost

@netlify Netlify
Copy link

netlify bot commented Jun 2, 2025 •
edited
Loading

✅ Deploy Preview for industrial-experience ready!

Name Link
🔨 Latest commit 27f0864
🔍 Latest deploy log https://app.netlify.com/projects/industrial-experience/deploys/684a9496f7b8d700088ff95b
😎 Deploy Preview https://deploy-preview-25--industrial-experience.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@flxlst09 flxlst09 requested a review from kathrinschalber June 2, 2025 08:37
kathrinschalber
kathrinschalber reviewed Jun 2, 2025
View reviewed changes
kathrinschalber
kathrinschalber requested changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@kathrinschalber kathrinschalber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! my feedback should be done quickly 🤗

flxlst09 and others added 5 commits June 2, 2025 18:12
@flxlst09 @kathrinschalber
Update docs/components/button/guide.md
23cb1ac 
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
@flxlst09 @kathrinschalber
Update docs/components/button/guide.md
bcb2c98 
Co-authored-by: Kathrin <123640803+kathrinschalber@users.noreply.github.com>
@flxlst09
docs: updating button usage guide after review
223b38b
@flxlst09
docs: updated option description
7caf31b
@flxlst09
docs: Update button guide
c75e3d5
@flxlst09 flxlst09 marked this pull request as ready for review June 4, 2025 11:23
@danielleroux danielleroux merged commit cc88634 into main Jun 16, 2025
5 checks passed
@danielleroux danielleroux deleted the docs/button-reworks branch June 16, 2025 11:12
@danielleroux danielleroux restored the docs/button-reworks branch June 24, 2025 14:58
danielleroux added a commit that referenced this pull request Jun 24, 2025
@danielleroux
Revert "docs: button renaming and usage guide adaptions (#25)"
4c7c1bb 
This reverts commit cc88634.
This was referenced Jun 24, 2025
Merged
Draft
danielleroux added a commit that referenced this pull request Jun 24, 2025
@danielleroux
Revert "docs: button renaming and usage guide adaptions (#25)" (#43)
7fdfeb5 
This reverts commit cc88634.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathrinschalber kathrinschalber kathrinschalber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flxlst09 @kathrinschalber @danielleroux