-
-
Notifications
You must be signed in to change notification settings - Fork 631
MySQL 5.6/8.0 charset #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks @denji ! Do you think anything needs to be added to |
@sidorares Yes, now everything should be fine. |
it's used to map from numeric code in mysql response to name for iconv-lite. Usually (always?) it's default collation code |
latin5: 30, | ||
armscii8: 32, | ||
cesu8: 33, | ||
utf8: 33, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mysql utf8 is in fact 'cesu8' encoding ( while what they call 'utf8mb4' is normal utf8 ), that is why cesu8 was there originally. It would be good to have more tests to validate this, see some discussion here - #374 (comment)
- UTF16-LE codec via iconv-lite. - Short charset aliases for the default collation.
Synchronized with the MySQL version 8.0 #492