Skip to content

fix(typings): allow indexing Types with FieldPacket.type #4582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DylanMerigaud wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(typings): allow indexing Types with FieldPacket.type #4582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/tsc-build/mysql/constants/Types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ import { mysql } from '../../index.test.js';
const BLOB: number = mysql.Types.BLOB;
const DECIMAL: string = mysql.Types[0x00];
const DOUBLE: string = mysql.Types[5];

const typeName = (field: mysql.FieldPacket): string | undefined =>
field.type === undefined ? undefined : mysql.Types[field.type];

// @ts-expect-error: A type code maps to its name, a string
const BLOB_CODE: number = mysql.Types[BLOB];
6 changes: 6 additions & 0 deletions test/tsc-build/promise/constants/Types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@ import { mysqlp as mysql } from '../../index.test.js';
const BLOB: number = mysql.Types.BLOB;
const DECIMAL: string = mysql.Types[0x00];
const DOUBLE: string = mysql.Types[5];

const typeName = (field: mysql.FieldPacket): string | undefined =>
field.type === undefined ? undefined : mysql.Types[field.type];

// @ts-expect-error: A type code maps to its name, a string
const BLOB_CODE: number = mysql.Types[BLOB];
1 change: 1 addition & 0 deletions typings/mysql/lib/constants/Types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ interface Types {
0xfd: string;
0xfe: string;
0xff: string;
[key: number]: string;

DECIMAL: number;
TINY: number;
Expand Down
Loading