Skip to content

fix(named-placeholders): improve handling of mixed/nested quotes in query parsing#4011

Merged
wellwelwel merged 1 commit intosidorares:masterfrom
Tushar-Banswal-spraxa:chore/upgrade-named-placeholder
Jan 15, 2026
Merged

fix(named-placeholders): improve handling of mixed/nested quotes in query parsing#4011
wellwelwel merged 1 commit intosidorares:masterfrom
Tushar-Banswal-spraxa:chore/upgrade-named-placeholder

Conversation

@Tushar-Banswal-spraxa
Copy link
Contributor

@Tushar-Banswal-spraxa Tushar-Banswal-spraxa commented Jan 15, 2026

Upgrade named-placeholders from version 1.1.3 to 1.1.6

We are using the mysql2 package in our application, and currently maintain a custom patch to address the following bug:

This issue has been resolved in named-placeholders version 1.1.6. If mysql2 is updated to use this latest version, we will be able to remove our custom patch or resolution.

This is a patch-level upgrade and does not introduce any breaking changes.

@wellwelwel
Copy link
Collaborator

wellwelwel commented Jan 15, 2026

Hi and thanks, @Tushar-Banswal-spraxa 🙋🏻‍♂️

The named-placeholder is already updated in the package-lock.json:

node-mysql2/package-lock.json

Lines 3777 to 3779 in e58d520

"node_modules/named-placeholders": {
"version": "1.1.6",
"resolved": "https://registry.npmjs.org/named-placeholders/-/named-placeholders-1.1.6.tgz",

For new installations, it already comes in the same version as above (v1.1.6), due to the ^ prefix.

For users who already have MySQL2 installed, updating sub-dependencies doesn't usually happen by itself and depends on npm update (or npm update named-placeholders, in this case).


On the other hand, it's interesting to consider that named-placeholders is not "just" a sub-dependency: it is exposed to the end user and its patches are directly reflected in MySQL2 and its users.

I believe that named-placeholder new releases should simultaneously generate new releases for MySQL2, just like the development dependencies we use (e.g., ESLint, Docusaurus, React), and they probably could receive the same or similar commit messages, for example:

fix(named-placeholders): improve handling of mixed/nested quotes in query parsing

Note

Using build(deps): prefix won't force a new release.

@wellwelwel wellwelwel added the dependencies Pull requests that update a dependency file label Jan 15, 2026
@codecov

This comment was marked as off-topic.

@wellwelwel wellwelwel changed the title build(deps): update named-placeholders to version 1.1.6 fix(named-placeholders): improve handling of mixed/nested quotes in query parsing Jan 15, 2026
@wellwelwel wellwelwel merged commit 3e00cd7 into sidorares:master Jan 15, 2026
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments