chore: fix container image reproducibility #7115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
reviewed
Apr 20, 2023
| @@ -663,6 +665,8 @@ COPY --from=pkg-grub / / | |||
| COPY --from=unicode-pf2 /usr/share/grub/unicode.pf2 /usr/share/grub/unicode.pf2 | |||
|
|
|||
| FROM alpine:3.17.2 AS installer-image | |||
| ARG SOURCE_DATE_EPOCH | |||
There was a problem hiding this comment.
SOURCE_DATE_EPOCH comes from buildkit?
frezbo
reviewed
Apr 24, 2023
| @@ -575,6 +578,7 @@ local integration_pipelines = [ | |||
| Pipeline('cron-integration-qemu-race', default_pipeline_steps + [build_race, integration_qemu_race], [default_cron_pipeline]) + cron_trigger(['nightly']), | |||
| Pipeline('cron-integration-qemu-csi', default_pipeline_steps + [integration_qemu_csi], [default_cron_pipeline]) + cron_trigger(['nightly']), | |||
| Pipeline('cron-integration-images', default_pipeline_steps + [integration_images, integration_sbcs], [default_cron_pipeline]) + cron_trigger(['nightly']), | |||
| Pipeline('cron-integration-reproducibility-test', default_pipeline_steps + [integration_reproducibility_test], [default_cron_pipeline]) + cron_trigger(['nightly']), | |||
There was a problem hiding this comment.
do we need this nighty where we built with a fresh cache, seems to aggressive, maybe weekly and before release
There was a problem hiding this comment.
I'll see how long it takes in the CI. but in general whole nightly passes fine except for extensions which is basically launching a Talos build which waits for extensions build which in turn wants another whole machine (in terms of resource claims). I think proper fix is to lower resource claims for extensions build
frezbo
approved these changes
Apr 24, 2023
|
/promote integration-reproducibility |
Also provide make targets to sign the images. Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
Unix4ever
approved these changes
Apr 24, 2023
|
/promote integration-reproducibility |
1 similar comment
|
/promote integration-reproducibility |
|
/m |
Merged
mrmichaeladavis
added a commit
to mrmichaeladavis/talos
that referenced
this pull request
Apr 29, 2023
Adds back in the required TARGETARCH for installer so extensions can be built off installer again as nvidia nonfree extension building was broken. Fixes: siderolabs#7155 Refs: siderolabs#7115 Signed-off-by: Michael A. Davis <6325127+mrmichaeladavis@users.noreply.github.com>
smira
pushed a commit
to mrmichaeladavis/talos
that referenced
this pull request
May 1, 2023
Adds back in the required TARGETARCH for installer so extensions can be built off installer again as nvidia nonfree extension building was broken. Fixes: siderolabs#7155 Refs: siderolabs#7115 Signed-off-by: Michael A. Davis <6325127+mrmichaeladavis@users.noreply.github.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com>
smira
pushed a commit
to smira/talos
that referenced
this pull request
May 8, 2023
Adds back in the required TARGETARCH for installer so extensions can be built off installer again as nvidia nonfree extension building was broken. Fixes: siderolabs#7155 Refs: siderolabs#7115 Signed-off-by: Michael A. Davis <6325127+mrmichaeladavis@users.noreply.github.com> Signed-off-by: Andrey Smirnov <andrey.smirnov@talos-systems.com> (cherry picked from commit d4e94f7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provide make targets to sign the images.