cluster create refactor #11862
Merged
cluster create refactor #11862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orzelius
force-pushed
the
create-cluster-refactor
branch
6 times, most recently
from
02abc75 to
b9bc716
Compare
Orzelius
force-pushed
the
create-cluster-refactor
branch
2 times, most recently
from
1743274 to
b9bc716
Compare
frezbo
reviewed
Sep 24, 2025
cmd/talosctl/cmd/mgmt/cluster/create/clusterops/configmaker/internal/makers/common.go
Outdated
Show resolved
Hide resolved
frezbo
reviewed
Sep 24, 2025
cmd/talosctl/cmd/mgmt/cluster/create/clusterops/configmaker/internal/makers/common.go
Outdated
Show resolved
Hide resolved
frezbo
reviewed
Sep 24, 2025
cmd/talosctl/cmd/mgmt/cluster/create/clusterops/configmaker/internal/makers/common_test.go
Outdated
Show resolved
Hide resolved
* Create the following packages under `/create`: - `flags` containing the pflag.Value implementations - `clusterops` containing the options for cluster creation - `configmaker` containing the logic that aids in creation of talos and provision configuration for cluster creation - internal `makers` and `siderolinkbuilder` packages that hide the internal logic that configmaker uses * Remove code duplication of default values. Now all default values come from the clusterops Get functions. * Add unit tests for flag implementations. * Add tests that compare machine configs generated for cluster create to default configs. These tests also functions as snapshot tests and will asure no undesired changes pass through in the future unnoticed. Signed-off-by: Orzelius <33936483+Orzelius@users.noreply.github.com>
Orzelius
force-pushed
the
create-cluster-refactor
branch
from
a6bc0fb to
65a6609
Compare
|
/m |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the cluster creation code (once more) to assure easy maintainability and testability
/create:flagscontaining the pflag.Value implementationsclusteropscontaining the options for cluster creationconfigmakercontaining the logic that aids in creation of talos and provision configuration for cluster creationmakersandsiderolinkbuilderpackages that hide the internal logic that configmaker usesThese tests also functions as snapshot tests and will asure no undesired changes pass through in the future unnoticed.
Potential further improvements that could be made if judged beneficial enough:
StateDir,CniBinPath,TalosconfigDestinationetc)part of #11404