Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nvme Kernel Modules Missing #9214

Closed
zzachattack2 opened this issue Aug 22, 2024 · 3 comments · Fixed by #9219
Closed

Nvme Kernel Modules Missing #9214

zzachattack2 opened this issue Aug 22, 2024 · 3 comments · Fixed by #9219
Assignees
@smira

Comments

@zzachattack2
Copy link

The nvme host (RDMA only) and nvme target (all) modules are built with the kernel in pkgs, but are not included in the Talos base image.

CONFIG_NVME_RDMA=m
CONFIG_NVME_TARGET=m
CONFIG_NVME_TARGET_LOOP=m
CONFIG_NVME_TARGET_RDMA=m
CONFIG_NVME_TARGET_FC=m
CONFIG_NVME_TARGET_TCP=m

Discussed on slack.
@smira
Copy link
Member

smira commented Aug 22, 2024

Ref: siderolabs/pkgs#906

@smira smira self-assigned this Aug 23, 2024
@smira smira mentioned this issue Aug 23, 2024
Merged
@zzachattack2
Copy link
Author

zzachattack2 commented Aug 25, 2024 •
edited
Loading

Thank you! Checked the fix but it is missing the one nvme host driver that was compiled as a module... the host RDMA one (nvme/host/nvme-rdma.ko).

@smira
Copy link
Member

smira commented Aug 26, 2024

Thank you! Checked the fix but it is missing the one nvme host driver that was compiled as a module... the host RDMA one (nvme/host/nvme-rdma.ko).

True, thank you, I don't know how I missed that.

smira added a commit to smira/talos that referenced this issue Aug 26, 2024
@smira
fix: add missing host/nvme-rdma
8234808 
See siderolabs#9214

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira smira mentioned this issue Aug 26, 2024
Merged
@smira smira mentioned this issue Sep 2, 2024
Closed
smira added a commit to smira/talos that referenced this issue Sep 25, 2024
@smira
fix: add NVMe target kernel modules
d60584c 
Fixes siderolabs#9214

This finishes the work which started in
siderolabs/pkgs#906, but it never got finished.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit f57d1f0)
smira added a commit to smira/talos that referenced this issue Sep 25, 2024
@smira
fix: add missing host/nvme-rdma
bc675dd 
See siderolabs#9214

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 8234808)
smira added a commit to smira/talos that referenced this issue Sep 25, 2024
@smira
fix: add NVMe target kernel modules
1916434 
Fixes siderolabs#9214

This finishes the work which started in
siderolabs/pkgs#906, but it never got finished.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit f57d1f0)
smira added a commit to smira/talos that referenced this issue Sep 25, 2024
@smira
fix: add missing host/nvme-rdma
4a4ee0b 
See siderolabs#9214

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 8234808)
smira added a commit to smira/talos that referenced this issue Sep 25, 2024
@smira
fix: add NVMe target kernel modules
63b59eb 
Fixes siderolabs#9214

This finishes the work which started in
siderolabs/pkgs#906, but it never got finished.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit f57d1f0)
smira added a commit to smira/talos that referenced this issue Sep 25, 2024
@smira
fix: add missing host/nvme-rdma
c95d1fe 
See siderolabs#9214

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 8234808)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add NVMe target kernel modules siderolabs/talos
2 participants
@smira @zzachattack2