Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set environment variables early from the command line #7696

Closed
Tracked by #7561
smira opened this issue Sep 1, 2023 · 0 comments · Fixed by #7704
Closed
Tracked by #7561

set environment variables early from the command line #7696

smira opened this issue Sep 1, 2023 · 0 comments · Fixed by #7704
Assignees
@smira

Comments

@smira
Copy link
Member

smira commented Sep 1, 2023 •
edited
Loading

Talos supports passing environments variables before machine config is loaded via talos.environment= kernel arg, but it doesn't actually apply them to the process environment up until the machine config is available.

If we apply those env vars early, it might allow to use the HTTP proxy for:

  • loading the machine config
  • establishing the SideroLink API (?)
@smira smira mentioned this issue Sep 1, 2023
Closed
@smira smira self-assigned this Sep 4, 2023
@smira smira mentioned this issue Sep 4, 2023
Merged
smira added a commit to smira/talos that referenced this issue Sep 5, 2023
@smira
feat: set environment variables early in the boot
e713043 
Fixes siderolabs#7696

This allows to set env variables from `talos.environment=` command line
arg.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit d91b5b3)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@smira smira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: set environment variables early in the boot smira/talos
1 participant
@smira