Skip to content

Commit

Permalink
fix: do not stop udevd before unmounting volumes
Browse files Browse the repository at this point in the history
As udevd is required by cryptsetup which will timeout if udevd is not working, do not stop it in StopServicesEphemeral, but let StopAllServices handle udev shutdown after cryptsetup close is called

Ref: https://bbs.archlinux.org/viewtopic.php?id=162415

Signed-off-by: Dmitry Sharshakov <dmitry.sharshakov@siderolabs.com>
  • Loading branch information
dsseng committed Oct 7, 2024
1 parent 6a08105 commit 7acadc0
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,7 @@ func StartAllServices(runtime.Sequence, any) (runtime.TaskExecutionFunc, string)
func StopServicesEphemeral(runtime.Sequence, any) (runtime.TaskExecutionFunc, string) {
return func(ctx context.Context, logger *log.Logger, r runtime.Runtime) (err error) {
// stopping 'cri' service stops everything which depends on it (kubelet, etcd, ...)
return system.Services(nil).StopWithRevDepenencies(ctx, "cri", "udevd", "trustd")
return system.Services(nil).StopWithRevDepenencies(ctx, "cri", "trustd")
}, "stopServicesForUpgrade"
}

Expand Down

0 comments on commit 7acadc0

Please sign in to comment.