feat: provide an option to overwrite some args in AppendAll #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See siderolabs/talos#3011 Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
|
/approve |
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 8, 2021
Fixes siderolabs#3011 See also siderolabs/go-procfs#8 We don't want to allow all the kernel args to be overridden, as this might compromise KSPP, but we would rather allow some args to be overridden explicitly. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
Unix4ever
approved these changes
Jan 8, 2021
andrewrynhard
approved these changes
Jan 8, 2021
|
/lgtm |
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 8, 2021
Fixes siderolabs#3011 See also siderolabs/go-procfs#8 We don't want to allow all the kernel args to be overridden, as this might compromise KSPP, but we would rather allow some args to be overridden explicitly. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
talos-bot
pushed a commit
to smira/talos
that referenced
this pull request
Jan 8, 2021
Fixes siderolabs#3011 See also siderolabs/go-procfs#8 We don't want to allow all the kernel args to be overridden, as this might compromise KSPP, but we would rather allow some args to be overridden explicitly. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
talos-bot
pushed a commit
to siderolabs/talos
that referenced
this pull request
Jan 8, 2021
Fixes #3011 See also siderolabs/go-procfs#8 We don't want to allow all the kernel args to be overridden, as this might compromise KSPP, but we would rather allow some args to be overridden explicitly. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 12, 2021
fix: bring up bonded interfaces correctly on packet This probably fixes bonding in general if 2nd link in the bond is down. For packet, set additional options for the bonded interface. In networkd, add interfaces filtered out by link status as ignored to make them available as bond subinterfaces. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit 5325a66) fix: allow 'console' argument in kernel args to be always overridden Fixes siderolabs#3011 See also siderolabs/go-procfs#8 We don't want to allow all the kernel args to be overridden, as this might compromise KSPP, but we would rather allow some args to be overridden explicitly. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit d19486a) fix: pick first interface valid hostname (vs. last one) Looks like the code before change in siderolabs#1578 returned the first hostname found while interating over interfaces and addressing methods, but siderolabs#1578 supposedly inadvertently flipped that to iterate over all interfaces (so last interface wins). Problem is that both `DHCP` and `Static` addressing methods provide hostnames, while DHCP hostname comes from DHCP server, while `Static` defines hostname as `talos-10-5-0-2` (by IP). If we were to fix it for real, we should build a list of hostname with priorities coming from different sources and pick a hostname with the highest priority, so this fix is more of a bandaid rather than a real fix. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit af5c34b)
smira
added a commit
to smira/talos
that referenced
this pull request
Jan 12, 2021
fix: bring up bonded interfaces correctly on packet This probably fixes bonding in general if 2nd link in the bond is down. For packet, set additional options for the bonded interface. In networkd, add interfaces filtered out by link status as ignored to make them available as bond subinterfaces. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit 5325a66) fix: allow 'console' argument in kernel args to be always overridden Fixes siderolabs#3011 See also siderolabs/go-procfs#8 We don't want to allow all the kernel args to be overridden, as this might compromise KSPP, but we would rather allow some args to be overridden explicitly. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit d19486a) fix: pick first interface valid hostname (vs. last one) Looks like the code before change in siderolabs#1578 returned the first hostname found while interating over interfaces and addressing methods, but siderolabs#1578 supposedly inadvertently flipped that to iterate over all interfaces (so last interface wins). Problem is that both `DHCP` and `Static` addressing methods provide hostnames, while DHCP hostname comes from DHCP server, while `Static` defines hostname as `talos-10-5-0-2` (by IP). If we were to fix it for real, we should build a list of hostname with priorities coming from different sources and pick a hostname with the highest priority, so this fix is more of a bandaid rather than a real fix. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit af5c34b) refactor: define default kernel flags in machinery instead of procfs That change should make Talos updates more straightforward in any projects that depend on Talos. Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com> (cherry picked from commit 7b6c4bc)
talos-bot
pushed a commit
to siderolabs/talos
that referenced
this pull request
Jan 12, 2021
fix: bring up bonded interfaces correctly on packet This probably fixes bonding in general if 2nd link in the bond is down. For packet, set additional options for the bonded interface. In networkd, add interfaces filtered out by link status as ignored to make them available as bond subinterfaces. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit 5325a66) fix: allow 'console' argument in kernel args to be always overridden Fixes #3011 See also siderolabs/go-procfs#8 We don't want to allow all the kernel args to be overridden, as this might compromise KSPP, but we would rather allow some args to be overridden explicitly. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit d19486a) fix: pick first interface valid hostname (vs. last one) Looks like the code before change in #1578 returned the first hostname found while interating over interfaces and addressing methods, but #1578 supposedly inadvertently flipped that to iterate over all interfaces (so last interface wins). Problem is that both `DHCP` and `Static` addressing methods provide hostnames, while DHCP hostname comes from DHCP server, while `Static` defines hostname as `talos-10-5-0-2` (by IP). If we were to fix it for real, we should build a list of hostname with priorities coming from different sources and pick a hostname with the highest priority, so this fix is more of a bandaid rather than a real fix. Signed-off-by: Andrey Smirnov <smirnov.andrey@gmail.com> (cherry picked from commit af5c34b) refactor: define default kernel flags in machinery instead of procfs That change should make Talos updates more straightforward in any projects that depend on Talos. Signed-off-by: Artem Chernyshev <artem.0xD2@gmail.com> (cherry picked from commit 7b6c4bc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See siderolabs/talos#3011
Signed-off-by: Andrey Smirnov smirnov.andrey@gmail.com