fix: honor values when reading GPT partition table #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frezbo
approved these changes
Jul 29, 2025
that's where I stopped yesterday - I will do tests and take it out of draft |
Keep using values from the GPT header on read flow (vs. the new partition flow), and trust whatever it says. Fixes siderolabs#134 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
I added unit-tests - they both fail with |
Unix4ever
approved these changes
Jul 29, 2025
frezbo
approved these changes
Jul 29, 2025
|
/m |
smira
added a commit
to smira/talos
that referenced
this pull request
Jul 29, 2025
Import the fix from siderolabs/go-blockdevice#135 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Jul 30, 2025
Import the fix from siderolabs/go-blockdevice#135 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit d62e255)
smira
added a commit
to smira/talos
that referenced
this pull request
Jul 30, 2025
Import the fix from siderolabs/go-blockdevice#135 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit d62e255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep using values from the GPT header on read flow (vs. the new partition flow), and trust whatever it says.
Fixes #134