This repository has been archived by the owner on Dec 12, 2023. It is now read-only.
Add configurable cookie domain property #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BracketJohn
suggested changes
Nov 10, 2022
src/module.ts
Outdated
| @@ -44,6 +44,13 @@ declare interface SessionOptions { | |||
| * @docs https://github.com/unjs/unstorage | |||
| */ | |||
| storageOptions: CreateStorageOptions, | |||
| /** | |||
| * Set the cookie domain | |||
There was a problem hiding this comment.
Can you expand this a bit, eg, what does it mean if the domain for a cookie is set vs it being null?
Linking to a relevant part of MDN docs would also be useful here (:
There was a problem hiding this comment.
Hi, @BracketJohn. Thanks for response. Added a fix, my mistake)
There was a problem hiding this comment.
No worries, thanks for iterating here with me (:
BracketJohn
reviewed
Nov 10, 2022
Co-authored-by: Nils <nils.jonalik@rwth-aachen.de>
BracketJohn
approved these changes
Nov 10, 2022
|
Merged, thanks @blumgart for the issue + the awesome contribution ❤️ Here's the release: https://github.com/sidebase/nuxt-session/releases/tag/0.2.3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19 .