Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rewrite Module to support SSR rendering #26

Merged
merged 44 commits into from
Feb 13, 2024
Merged

feat: Rewrite Module to support SSR rendering #26

merged 44 commits into from
Feb 13, 2024

Conversation

zoey-kaiser
Copy link
Member

@zoey-kaiser zoey-kaiser commented Feb 13, 2024

Contributes to #25

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@zoey-kaiser zoey-kaiser mentioned this pull request Feb 13, 2024
4 tasks
@zoey-kaiser
Copy link
Member Author

zoey-kaiser commented Feb 13, 2024

Size without old composables: 7.47kb
Size with old composables: 8.78 kB

I think this slight increase of 1.5kB is not impactful enough to kick out the old HTML To PDF logic, as some people may still prefer to use it in certain use cases, even if we are generally pushing in the direction of rendering server side.

@zoey-kaiser zoey-kaiser marked this pull request as ready for review February 13, 2024 03:19
@zoey-kaiser zoey-kaiser merged commit 63ed29d into main Feb 13, 2024
1 check passed
@zoey-kaiser zoey-kaiser deleted the v2-rewrite branch February 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant