Skip to content

feat: Add option to install DrizzleORM #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Conversation

zoey-kaiser
Copy link
Member

@zoey-kaiser zoey-kaiser commented Oct 12, 2023

Depends on #30

Adds support for another ORM: Drizzle.

Questions:

  • As I added another ORM, that conflicts with PrismaORM, do we want to seperate which ORM you want into another questions, or keep it so that in theory you could install both? In this PR, as it is a POC, I added it to the modules list, meaning through this PR, you could install two different ORMS.

Checklist:

  • issue number linked above after pound (#)
    • replace "Closes " with "Contributes to" or other if this PR does not close the issue
  • manually checked my feature / checking not applicable
  • wrote tests / testing not applicable
  • attached screenshots / screenshot not applicable

@zoey-kaiser zoey-kaiser changed the base branch from main to update-design October 12, 2023 19:17
@zoey-kaiser zoey-kaiser marked this pull request as ready for review October 12, 2023 19:21
@zoey-kaiser zoey-kaiser marked this pull request as draft October 12, 2023 19:22
@zoey-kaiser
Copy link
Member Author

zoey-kaiser commented Oct 12, 2023

@BracketJohn, the next questions for me would be:

  • Is my implementation good? I used the Drizzle docs to integrate it into Nuxt, as well as this tutorial: https://dev.to/aaronksaunders/drizzle-orm-sqlite-and-nuxt-js-getting-started-374m
  • I decided to use better-sqlite3 as the database.
    • PrismaORM uses sqlite, so it made sense to stick with it
    • This packaged looked the best of the supported sqlite packages
  • Do we want to add some kind of middleware to make using the queries even easier (like with PrismaORM)
  • Do you have any other recommendations on how we could improve the DX of Drizzle in sidebase?

Base automatically changed from update-design to main January 8, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant