Watching startTimeAttr and restarting timer if changed #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting... never thought of this scenario. Thanks for the PR 👍 Can you please add some test for this change? |
|
I do need this as well. Related to issue #139. |
|
@alduro I am merging this now. Since there is not enough tests around this. Can you verify if it didn't break anything? |
siddii
added a commit
that referenced
this pull request
Dec 18, 2014
Watching startTimeAttr and restarting timer if changed
|
Here is a new release - https://github.com/siddii/angular-timer/releases/tag/v1.2.1 |
|
Awesome. Thanks, @siddii! |
|
@siddii was the dist directory rebuilt for v1.2.1? Still looks like v1.2.0. |
|
Good point, I'll check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timer is running and the startTimeAttr is changed, the timer will be restarted.