Skip to content

Fix staging deployment with now #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Fix staging deployment with now #35

merged 2 commits into from
Apr 13, 2020

Conversation

siddharthkp
Copy link
Owner

@siddharthkp siddharthkp commented Apr 13, 2020

The staging deployment was using a version from npm instead of the dev version from yarn workspaces. Needed to change a few things from the zeit dashboard + tiny changes to the build script for docs.

  • bonus: Added version in the docs header

@vercel
Copy link

vercel bot commented Apr 13, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/sid/react-ui/fm760ls39
✅ Preview: https://react-ui-git-check-zeit-setup.sid.now.sh

@siddharthkp siddharthkp changed the title test if we can get dev version in staging Fix staging deployment with now Apr 13, 2020
@siddharthkp siddharthkp added bug Something isn't working enhancement New feature or request labels Apr 13, 2020
@siddharthkp siddharthkp marked this pull request as ready for review April 13, 2020 18:59
@siddharthkp siddharthkp merged commit 454fdc7 into master Apr 13, 2020
@siddharthkp siddharthkp deleted the check-zeit-setup branch April 13, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant