Skip to content

Commit

Permalink
[ELF][S390X] Skip tests that fail due to buggy code produced by GCC
Browse files Browse the repository at this point in the history
`bno-symbolic` and `canonical-plt` still fail with GCC 15.
`rodata-name` started failing with GCC 14.
  • Loading branch information
sicherha committed Jan 24, 2025
1 parent 5cc0e9d commit a570e89
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/bno-symbolic.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# GCC produces buggy code for this test case on s390x.
# https://sourceware.org/bugzilla/show_bug.cgi?id=29655
[ $MACHINE = s390x ] && $CC -v 2>&1 | grep -E '^gcc version 1[0-4]\.' && skip
[ $MACHINE = s390x ] && $CC -v 2>&1 | grep -E '^gcc version 1[0-5]\.' && skip

cat <<EOF | $CC -c -fPIC -o$t/a.o -xc -
int foo = 4;
Expand Down
2 changes: 1 addition & 1 deletion test/canonical-plt.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# GCC produces buggy code for this test case on s390x.
# https://sourceware.org/bugzilla/show_bug.cgi?id=29655
[ $MACHINE = s390x ] && $CC -v 2>&1 | grep -E '^gcc version 1[0-4]\.' && skip
[ $MACHINE = s390x ] && $CC -v 2>&1 | grep -E '^gcc version 1[0-5]\.' && skip

cat <<EOF | $CC -o $t/a.so -fPIC -shared -xc -
void *foo() {
Expand Down
4 changes: 4 additions & 0 deletions test/rodata-name.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@
# Concretely speaking, ARM as uses "@" as a start of a comment.
[ $MACHINE = arm ] && skip

# GCC produces buggy code for this test case on s390x.
# https://sourceware.org/bugzilla/show_bug.cgi?id=29655
[ $MACHINE = s390x ] && $CC -v 2>&1 | grep -E '^gcc version 1[45]\.' && skip

cat <<'EOF' | $CC -c -o $t/a.o -x assembler -
.globl val1, val2, val3, val4, val5
Expand Down

0 comments on commit a570e89

Please sign in to comment.