feat: link toolbar show/hide 'Open in new tab' option #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new option for the Link toolbar icon/popup to disable the
"Open in new tab" option from showing in the UI. Specifying `"link"` as
a ToolbarItem is still supported, but you can now pass an object to
specify its options via `{ link: { showOpenInNewTab: false } }`, similar
to the `heading` toolbar item.
|
Published in v17.0.2 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in the thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Checklist
Describe Your Changes
This adds a new option for the Link toolbar icon/popup to disable the "Open in new tab" option from showing in the UI, for i.e. a Markdown serializer where target is not supported. Specifying
"link"as a ToolbarItem is still supported and the default is to show the "Open in new tab" option, but you can now pass an object instead to specify its options via{ link: { showOpenInNewTab: false } }, similar to theheadingtoolbar item.Does this PR affects any existing issues?