chore: check basic go types are covered

codegen/code_generator.go

@@ -23,6 +23,19 @@ import (
 	"golang.org/x/tools/imports"
 )
 
+// The minimum go type we need to map
+var goTypes = []string{
+	"byte",
+	"rune",
+	"bool",
+	"string",
+	"float32", "float64",
+	"int", "int8", "int16", "int32", "int64",
+	"uint", "uint8", "uint16", "uint32", "uint64",
+	"time.Time",
+	// "any", "sql.RawBytes", "json.RawMessage"
+}
+
 type Generator struct {
 	*bytes.Buffer
 	config             *Config
@@ -34,7 +47,7 @@ type Generator struct {
 	errs               []error
 }
 
-func newGenerator(cfg *Config, d dialect.Dialect) *Generator {
+func newGenerator(cfg *Config, d dialect.Dialect) (*Generator, error) {
 	gen := new(Generator)
 	gen.Buffer = new(bytes.Buffer)
 	gen.config = cfg
@@ -44,11 +57,17 @@ func newGenerator(cfg *Config, d dialect.Dialect) *Generator {
 	case '`':
 		gen.quoteRune = '"'
 	default:
-		gen.quoteRune = '"'
+		return nil, fmt.Errorf(`sqlgen: invalid quote character %q for string`, d.QuoteRune())
 	}
 	gen.dialect = d
 	gen.staticVar = d.QuoteVar(1) == d.QuoteVar(0)
 	gen.defaultColumnTypes = d.ColumnDataTypes()
+	// Check the dialect cover the basic go types
+	for _, t := range goTypes {
+		if _, ok := gen.defaultColumnTypes[t]; !ok {
+			return nil, fmt.Errorf(`sqlgen: SQL dialect %q missing column type mapping for type %q`, d.Driver(), t)
+		}
+	}
 	gen.columnTypes = make(map[string]*dialect.ColumnType)
 	for k, decl := range cfg.DataTypes {
 		gen.columnTypes[k] = &dialect.ColumnType{
@@ -61,7 +80,7 @@ func newGenerator(cfg *Config, d dialect.Dialect) *Generator {
 			SQLValuer:  decl.SQLValuer,
 		}
 	}
-	return gen
+	return gen, nil
 }
 
 func (g *Generator) LogError(err error) {

codegen/codegen.go

@@ -86,12 +86,15 @@ func Generate(c *Config) error {
 		return fmt.Errorf("sqlgen: missing dialect, please register your dialect first")
 	}
 
+	generator, err := newGenerator(cfg, dialect)
+	if err != nil {
+		return err
+	}
+
 	var (
-		srcDir    string
-		sources   = make([]string, len(cfg.Source))
-		generator = newGenerator(cfg, dialect)
+		srcDir  string
+		sources = make([]string, len(cfg.Source))
 	)
-
 	copy(sources, cfg.Source)
 
 	// Resolve every source provided

codegen/config.go

@@ -166,12 +166,12 @@ func (c *Config) initIfEmpty() {
 	if c.Database.Operator.Filename == "" {
 		c.Database.Operator.Filename = "operator.go"
 	}
-	if c.Migration == nil {
-		c.Migration = new(MigrationConfig)
-	}
-	c.Migration.Dir = "migrate"
-	c.Migration.Package = "migrate"
-	c.Migration.Filename = "migrate.go"
+	// if c.Migration == nil {
+	// 	c.Migration = new(MigrationConfig)
+	// }
+	// c.Migration.Dir = "migrate"
+	// c.Migration.Package = "migrate"
+	// c.Migration.Filename = "migrate.go"
 	if c.DataTypes == nil {
 		c.DataTypes = make(map[string]DataType)
 	}

codegen/dialect/mysql/column_type.go

@@ -16,6 +16,11 @@ func (s *mysqlDriver) ColumnDataTypes() map[string]*dialect.ColumnType {
 			Valuer:   "(string)({{goPath}})",
 			Scanner:  "{{addrOfGoPath}}",
 		},
+		"byte": {
+			DataType: s.columnDataType("CHAR(1)"),
+			Valuer:   "(string)({{goPath}})",
+			Scanner:  "{{addrOfGoPath}}",
+		},
 		"string": {
 			DataType: s.columnDataType("VARCHAR(255)", ""),
 			Valuer:   "(string)({{goPath}})",

codegen/dialect/postgres/column_type.go

@@ -17,6 +17,11 @@ func (s *postgresDriver) ColumnDataTypes() map[string]*dialect.ColumnType {
 			Valuer:   "(string)({{goPath}})",
 			Scanner:  "{{addrOfGoPath}}",
 		},
+		"byte": {
+			DataType: s.columnDataType("char(1)"),
+			Valuer:   "(string)({{goPath}})",
+			Scanner:  "{{addrOfGoPath}}",
+		},
 		"string": {
 			DataType: func(col dialect.GoColumn) string {
 				size := 255

codegen/dialect/sqlite/data_type.go

@@ -1,15 +1,33 @@
 package sqlite
 
 import (
+	"fmt"
+
 	"github.com/si3nloong/sqlgen/codegen/dialect"
 )
 
 func (s *sqliteDriver) ColumnDataTypes() map[string]*dialect.ColumnType {
 	return map[string]*dialect.ColumnType{
+		"rune": {
+			DataType: s.columnDataType("CHAR(1)"),
+			Valuer:   "(string)({{goPath}})",
+			Scanner:  "{{addrOfGoPath}}",
+		},
+		"byte": {
+			DataType: s.columnDataType("CHAR(1)"),
+			Valuer:   "(string)({{goPath}})",
+			Scanner:  "{{addrOfGoPath}}",
+		},
 		"string": {
-			DataType: s.columnDataType("TEXT"),
-			Valuer:   "string({{goPath}})",
-			Scanner:  "github.com/si3nloong/sqlgen/sequel/types.String({{addrOfGoPath}})",
+			DataType: func(col dialect.GoColumn) string {
+				size := 255
+				if n := col.Size(); n > 0 {
+					size = n
+				}
+				return fmt.Sprintf("VARCHAR(%d)", size)
+			},
+			Valuer:  "string({{goPath}})",
+			Scanner: "github.com/si3nloong/sqlgen/sequel/types.String({{addrOfGoPath}})",
 		},
 		"bool": {
 			DataType: s.columnDataType("INTEGER"),
@@ -76,6 +94,11 @@ func (s *sqliteDriver) ColumnDataTypes() map[string]*dialect.ColumnType {
 			Valuer:   "float64({{goPath}})",
 			Scanner:  "github.com/si3nloong/sqlgen/sequel/types.Float({{addrOfGoPath}})",
 		},
+		"time.Time": {
+			DataType: s.columnDataType("TEXT"),
+			Valuer:   "(time.Time)({{goPath}})",
+			Scanner:  "(*time.Time)({{addrOfGoPath}})",
+		},
 	}
 }
 

examples/testdata_test.go

@@ -23,7 +23,6 @@ func TestAll(t *testing.T) {
 			Package: "mysqldb",
 			Dir:     "./db/mysql",
 		},
-		Migration: &codegen.MigrationConfig{},
 		// QuoteIdentifier: true,
 		Exec: codegen.ExecConfig{
 			SkipEmpty: false,