Fix mysql8 signedness decoding #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The table metadata only contains signedness bits for integer columns. So in the case where there's 12 columns but only 1 integer column, mysql will use just one byte. Our calculation was saying there should be 2 bytes, and thus our buffer overruneth.
|
ping @shyiko, been getting quite a few pile-ons to zendesk/maxwell#1199 and would love to get a fix out |
|
Sorry, Ben. An insane amount of work lately. Merging in. |
roback
added a commit
to twingly/ecco
that referenced
this pull request
Apr 18, 2019
Only the following change: > TABLE_MAP event data deserialization on MySQL 8 (shyiko/mysql-binlog-connector-java#264) https://github.com/shyiko/mysql-binlog-connector-java/blob/master/CHANGELOG.md#0191---2019-03-28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table metadata only contains signedness bits for integer columns.
So in the case where there's 12 columns but only 1 integer column, mysql
will use just one byte. Our calculation was saying there should be 2
bytes, and thus our buffer overruneth.