Skip to content

[Fabric] Convert UIView to RCTUIView shim #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

shwanton
Copy link
Owner

@shwanton shwanton commented Nov 23, 2022

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Fabric on macOS implementation:

Replacing references of UIView to RCTUIView shim

NOTE: microsoft#1519 adds the RCTUIKit imports required for this branch. Once that is merged, this PR will not have those changes.

Changelog

[macOS][Fabric] - Replacing references of UIView to RCTUIView shim

Test Plan

[x] Build RNTester-macOS w/ Fabric - doesn’t run yet, but no UIView errors
CleanShot 2022-11-23 at 13 04 18

Build RNTester-macOS_2022-11-23T13-02-55.txt

[x] Build RNTester - iOS w/ Fabric - should work
https://user-images.githubusercontent.com/96719/203647093-7d05dff3-760a-4053-9d4b-164d133482aa.mp4

[x] Build RNTester-macOS w/ Paper - should work
https://user-images.githubusercontent.com/96719/203647140-a37bbc9e-53b1-4628-b1e7-7c4a14754c58.mp4

[x] Build RNTester - iOS w/ Paper - should work
https://user-images.githubusercontent.com/96719/203646958-e64d1c13-580f-446d-8b87-d452f7c38932.mp4

@shwanton
Copy link
Owner Author

Closed in favor of microsoft#1524

@shwanton shwanton closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant