EFI boot support for Fedora #5
Conversation
install.sh
Outdated
| # BLS etries have 'kernel' class, copy corresponding icon | ||
| if [[ -d /boot/loader/entries && -e ${THEME}-master/icons/${ID}.png ]] | ||
| then | ||
| cp ${THEME}-master/icons/${ID}.png ${THEME}-master/icons/kernel.png | ||
| fi |
There was a problem hiding this comment.
I'm not aware of other distros, since I'm using Fedora, and they introduced Bootloader Specification in version 30 (https://fedoraproject.org/wiki/Changes/BootLoaderSpecByDefault). Anyways, nothing is preventing other distros from implementing it in future releases.
There was a problem hiding this comment.
Ah, I was not aware of that, thanks. Still, grub_class kernel part seems to be Fedora/RH specific change to BLS (https://fedoraproject.org/wiki/Changes/BootLoaderSpecByDefault#Differences_from_BootLoaderSpec). Would you mind to move that code inside existing Fedora/RH elif block (lines 64..76)?
There was a problem hiding this comment.
Sure, no problem
|
Looks good, thank you! One small question though, see comment on lines 78 to 82 |
|
Merged, thank you! 😉 |
The theme doesn't get installed on Fedora with EFI enabled